Add explicit permissions to GitHub Actions workflows#91
Merged
Conversation
Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Define explicit permissions for workflow files
Add explicit permissions to GitHub Actions workflows
Nov 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security by adding explicit permission definitions to two GitHub Actions workflows that previously relied on default token permissions. By explicitly defining minimal permissions, the workflows follow the principle of least privilege.
- Adds
permissions: contents: readto the build job in nodejs.yml - Adds
permissions: contents: readto the publish-npm job in publish.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/nodejs.yml |
Adds explicit contents: read permission to build job for code checkout and testing |
.github/workflows/publish.yml |
Adds explicit contents: read permission to publish-npm job; npm publishing uses separate npm_token secret |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liuliu-dev
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow files lacked explicit permission definitions, relying on default token permissions.
Changes
.github/workflows/nodejs.yml: Addedpermissions: contents: readto build job.github/workflows/publish.yml: Addedpermissions: contents: readto publish-npm jobBoth workflows only require read access to checkout code and run build/test commands. The publish workflow uses
npm_tokensecret for npm registry authentication, requiring no additional GitHub permissions.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.googleapis.comnode install.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.